Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFX Summer 2024: Service Mesh Performance #1246

Merged
merged 7 commits into from
May 15, 2024

Conversation

Yashsharma1911
Copy link
Contributor

No description provided.

@nate-double-u
Copy link
Member

Hi @Yashsharma1911, thanks for this!

@leecalcote & @gyohuangxin could you 👍 or approve this PR to confirm your participation?

@nate-double-u
Copy link
Member

Also, @Yashsharma1911, could you resolve the merge conflicts?

@Yashsharma1911
Copy link
Contributor Author

Also, @Yashsharma1911, could you resolve the merge conflicts?

Thankyou @nate-double-u merge conflicts are now resolved

Signed-off-by: Yash sharma <[email protected]>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-double-u
Copy link
Member

Thanks for the update, we're still waiting on a 👍 or approval from @gyohuangxin

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target programs/lfx-mentorship/2024/02-Jun-Aug/project_ideas.md, part of our process is moving from project ideas to the README as the LFX approves the project.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @Yashsharma1911

/approve
/hold

(hold while we wait for confirmation from @gyohuangxin)

Signed-off-by: Yash Sharma <[email protected]>
Copy link

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nate-double-u nate-double-u merged commit 6afcaad into cncf:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants