Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to more descriptive documentation. #4

Merged
merged 1 commit into from
Jun 1, 2015

Conversation

mgd722
Copy link
Contributor

@mgd722 mgd722 commented May 26, 2015

http://docs.cmv.io/en/1.3.3/widgets/Identify/ has much more detailed information and already covers the topic of how to author the config object.

@DavidSpriggs DavidSpriggs reopened this Jun 1, 2015
@DavidSpriggs
Copy link
Member

My bad, I was looking at the wrong repo, lol... merged and thanks!

DavidSpriggs added a commit that referenced this pull request Jun 1, 2015
Added link to more descriptive documentation.
@DavidSpriggs DavidSpriggs merged commit db85e9e into cmv:master Jun 1, 2015
@mgd722 mgd722 deleted the patch-1 branch June 1, 2015 15:29
@tmcgee
Copy link
Member

tmcgee commented Jun 6, 2015

@DavidSpriggs We don't want a hard-coded link to the documentation with a version number in it. Should be a relative link, yes?

@tmcgee
Copy link
Member

tmcgee commented Jun 6, 2015

@DavidSpriggs I just looked at the latest docs build and noticed that it does not create a valid hyperlink. Need to use markdown and link to a relative page.

@DavidSpriggs
Copy link
Member

Good point. Who wants to fix, @mgd722?

@mgd722
Copy link
Contributor Author

mgd722 commented Jun 8, 2015

Good catch, @tmcgee -- I'm definitely still getting the hang of this stuff. Looking at it again, though, everything on the widgets/Identify/ page really only details how to make a config file. Should that instead be moved to configure/identify/ and the widgets/Identify/ page be left blank?

@tmcgee
Copy link
Member

tmcgee commented Jun 23, 2015

I believe that this merge is causing the docs build process to fail. https://readthedocs.org/builds/cmv/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants