Fix typo spotted by Giulio possibly causing memory leak #8603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix obvious typo spotted by Giulio Eulisse. Thank you, Giulio! This typo has been in the code for ROOT6 back as far as 7_0_ROOT6_X, but was only recently introduced into the code for ROOT5 only very recently. The effect of this but is that a loop possibly invoking destructors terminates immediately, thereby possibly causing a memory leak.
I tested this fix with the unit test for the package and the entire short relval matrix, and all the tests pass.
As this is a bug fix, it should be expedited.
This fix will be identical in 7_4_X, 7_4_ROOT6_X, 7_5_X, and 7_5_ROOT5_X.