Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo spotted by Giulio possibly causing memory leak #8603

Merged
merged 1 commit into from
Mar 31, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 30, 2015

Fix obvious typo spotted by Giulio Eulisse. Thank you, Giulio! This typo has been in the code for ROOT6 back as far as 7_0_ROOT6_X, but was only recently introduced into the code for ROOT5 only very recently. The effect of this but is that a loop possibly invoking destructors terminates immediately, thereby possibly causing a memory leak.
I tested this fix with the unit test for the package and the entire short relval matrix, and all the tests pass.
As this is a bug fix, it should be expedited.
This fix will be identical in 7_4_X, 7_4_ROOT6_X, 7_5_X, and 7_5_ROOT5_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_4_X.

Fix typo spotted by Giulio possibly causing memory leak

It involves the following packages:

CommonTools/Utils

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@wmtan
Copy link
Contributor Author

wmtan commented Mar 30, 2015

@ktf This is the fix for the bug you spotted. It should propagate forward to 7_4_ROOT6_X, 7_5_X, and 7_5_ROOT5_X. Let me know if you want me to explicitly request it in any of those releases.
@wddgit FYI.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Mar 31, 2015

Current version is clearly wrong. Merging.

ktf added a commit that referenced this pull request Mar 31, 2015
Fix typo spotted by Giulio possibly causing memory leak
@ktf ktf merged commit 14849a1 into cms-sw:CMSSW_7_4_X Mar 31, 2015
@ktf
Copy link
Contributor

ktf commented Mar 31, 2015

Say thanks to clang.. ;-)

@cmsbuild
Copy link
Contributor

@wmtan wmtan deleted the FixTypoThatMayCauseMemoryLeak branch March 31, 2015 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants