-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiniAOD: fix bug in charge() #8570
MiniAOD: fix bug in charge() #8570
Conversation
A new Pull Request was created by @arizzi for CMSSW_7_5_X. fix bug in charge It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
The commit seems correct for e, mu, tau. However, I think that the charge will be opposite for W. I think that +24 is W+ and -24 is W-. |
I think you are right, I just fixed the fact that they were giving always -1. |
btw... I doubt we have W in packedCandidates! |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
-1 >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonSlimmer.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPrimaryVertexCleaner.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATSecondaryVertexSlimmer.cc /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc: In member function 'virtual void pat::PATPhotonProducer::produce(edm::Event&, const edm::EventSetup&)': /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc:361:15: error: 'class pat::Photon' has no member named 'setEcalPFClusterIso' aPhoton.setEcalPFClusterIso((_ecalPFClusterIsoMapH)[photonRef]); ^ /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-27-2300/src/PhysicsTools/PatAlgos/plugins/PATPhotonProducer.cc:362:15: error: 'class pat::Photon' has no member named 'setHcalPFClusterIso' aPhoton.setHcalPFClusterIso((_hcalPFClusterIsoMapH)[photonRef]); ^ you can see the results of the tests here: |
is the IB broken? how can the change of 4 signs in an accessor have any effect on that producer? |
yes, it is.. i just fixed it From: arizzi [[email protected]] is the IB broken? how can the change of 4 signs in an accessor have any effect on that producer? — |
can some L2 or above retrigger jenkins tests? |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
MiniAOD: fix bug in charge()
-1 Entering library rule at PhysicsTools/PatAlgos >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoMET/METPUSubtraction/plugins/GBRForestWriter.cc In file included from RecoEgammaElectronIdentification/a/RecoEgammaElectronIdentification_xr.cc:41: In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoEgamma/ElectronIdentification/src/classes.h:4: In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoEgamma/ElectronIdentification/interface/VersionedGsfElectronSelector.h:6: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/PhysicsTools/SelectorUtils/interface/VersionedSelector.h:104:31: error: typename is allowed for identifiers only using typename Selector::operator(); ~~~~~~~~~ ^ warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option] 1 warning generated. >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-03-28-2300/src/RecoMET/METPUSubtraction/plugins/JVFJetIdProducer.cc you can see the results of the tests here: |
fix sign of leptons in miniaod packed candidates