Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70x tau id trigger default config #1910

Merged
merged 5 commits into from
Jan 20, 2014

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Dec 20, 2013

Added default configurations for EDproducers necessary for ConfDB at HLT + added one missing consumes interface

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X.

70x tau id trigger default config

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Dec 20, 2013

to pre12 / 71X.

jpavel added a commit to jpavel/cmssw that referenced this pull request Dec 20, 2013
jpavel added a commit to jpavel/cmssw that referenced this pull request Dec 20, 2013
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 6, 2014

@jpavel
Copy link
Contributor Author

jpavel commented Jan 8, 2014

any news on the evaluation of this request? It is already in ConfDB template in CMSSW_7_0_0_pre11_HLT3

@slava77
Copy link
Contributor

slava77 commented Jan 15, 2014

looking at it

@slava77
Copy link
Contributor

slava77 commented Jan 15, 2014

@nclopezo David, jenkins report here didn't return any comparisons yet.
Probably needs to be restarted.


import RecoTauTag.RecoTau.RecoTauCleanerPlugins as cleaners

hpsPFTauProducerSansRefs = cms.EDProducer(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the nominal rule for cfi to have the same name as the defined producer?
hpsPFTauProducerSansRefs_cfi.py

https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAboutPythonConfigFile

@jpavel
Copy link
Contributor Author

jpavel commented Jan 15, 2014

Ah, I did not know about this rule - if such a rule indeed exists, the name in cfi can be changed without trouble.

@slava77
Copy link
Contributor

slava77 commented Jan 15, 2014

Hi Pavel

If it's not much trouble to rename, I'd prefer the cfi name matches the defined module instance name.

Thank you.

@jpavel
Copy link
Contributor Author

jpavel commented Jan 15, 2014

Sure, np
On 15/01/14 15:39, slava77 wrote:

Hi Pavel

If it's not much trouble to rename, I'd prefer the cfi name matches
the defined module instance name.

Thank you.


Reply to this email directly or view it on GitHub
#1910 (comment).

Dr. Pavel JEZ
postdoctoral researcher
Centre for Cosmology, Particle Physics and Phenomenology-CP3
Université Catholique de Louvain

@anton-a
Copy link

anton-a commented Jan 16, 2014

@Degano, @nclopezo can you please run jenkins for this PR

@cmsbuild
Copy link
Contributor

Pull request #1910 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

jpavel added a commit to jpavel/cmssw that referenced this pull request Jan 17, 2014
@cmsbuild
Copy link
Contributor

@jpavel
Copy link
Contributor Author

jpavel commented Jan 17, 2014

HLT database depends on this PR, so please try to merge it into 70x even if #1817 is not approved in time.

@ktf
Copy link
Contributor

ktf commented Jan 17, 2014

@slava77 @anton-a ?

@anton-a
Copy link

anton-a commented Jan 17, 2014

looking into it

@anton-a
Copy link

anton-a commented Jan 17, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jan 20, 2014
Reco fixes -- 70x tau id trigger default config
@ktf ktf merged commit 91c980d into cms-sw:CMSSW_7_0_X Jan 20, 2014
@jpavel jpavel deleted the 70x_TauID_TriggerDefaultConfig branch January 20, 2014 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants