-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
70x tau id trigger default config #1910
70x tau id trigger default config #1910
Conversation
A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X. 70x tau id trigger default config It involves the following packages: RecoTauTag/Configuration @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
to pre12 / 71X. |
any news on the evaluation of this request? It is already in ConfDB template in CMSSW_7_0_0_pre11_HLT3 |
looking at it |
@nclopezo David, jenkins report here didn't return any comparisons yet. |
|
||
import RecoTauTag.RecoTau.RecoTauCleanerPlugins as cleaners | ||
|
||
hpsPFTauProducerSansRefs = cms.EDProducer( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the nominal rule for cfi to have the same name as the defined producer?
hpsPFTauProducerSansRefs_cfi.py
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAboutPythonConfigFile
Ah, I did not know about this rule - if such a rule indeed exists, the name in cfi can be changed without trouble. |
Hi Pavel If it's not much trouble to rename, I'd prefer the cfi name matches the defined module instance name. Thank you. |
Sure, np
Dr. Pavel JEZ |
HLT database depends on this PR, so please try to merge it into 70x even if #1817 is not approved in time. |
looking into it |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it? |
Reco fixes -- 70x tau id trigger default config
Added default configurations for EDproducers necessary for ConfDB at HLT + added one missing consumes interface