Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safe DataFormats/DTRecHit #1304

Merged
merged 2 commits into from
Nov 10, 2013
Merged

Thread safe DataFormats/DTRecHit #1304

merged 2 commits into from
Nov 10, 2013

Conversation

Dr15Jones
Copy link
Contributor

Fixed thread safety issues (non-const statics and const_cast) find by the static analyzer.

@Dr15Jones
Removed unneeded const_cast
d86bb77 
Although the const_cast was not needed, it was showing up as a warning
by the thread-safety checker.
@Dr15Jones
Changed statics to const statics
a8b3dd3 
Previously, the function local statics were not declared const because
there was no way to easily set their values via the constructor. This
code was changed to use 'const function statics' where we use a helper
function to do the setup. This avoids thread-safety issues.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2013

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Thread safe DataFormats/DTRecHit

It involves the following packages:

DataFormats/DTRecHit

@nclopezo, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1168/summary.html

@slava77 slava77 mentioned this pull request Nov 7, 2013
Merged
@slava77
Copy link
Contributor

slava77 commented Nov 7, 2013

+1

tested in CMSSW_7_0_X_2013-11-05-1400 as sign269
in a combination of

all merge, compile, and run OK and there are no differences in outputs, as expected

This was referenced Nov 7, 2013
Merged
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

This was referenced Nov 7, 2013
Merged
Merged
Merged
Merged
ktf added a commit that referenced this pull request Nov 10, 2013
@ktf
Merge pull request #1304 from Dr15Jones/threadSafeDataFormatsDTRecHit
2a65c76 
Multithreading fixes -- Thread safe DataFormats/DTRecHit
@ktf ktf merged commit 2a65c76 into cms-sw:CMSSW_7_0_X Nov 10, 2013
@Dr15Jones Dr15Jones deleted the threadSafeDataFormatsDTRecHit branch November 14, 2013 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @slava77 @ktf