Add conversion tracks to tracking validation

Aim is to have something we can monitor (efficiency, fake rate) for
now, rather than assessing the exact physics performance.

Validation/RecoTrack/python/PostProcessorTracker_cfi.py

@@ -1,7 +1,7 @@
 import FWCore.ParameterSet.Config as cms
 
 postProcessorTrack = cms.EDAnalyzer("DQMGenericClient",
-    subDirs = cms.untracked.vstring("Tracking/Track/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackSeeding/*", "Tracking/TrackBuilding/*"),
+    subDirs = cms.untracked.vstring("Tracking/Track/*", "Tracking/TrackFromPV/*", "Tracking/TrackFromPVAllTP/*", "Tracking/TrackAllTPEffic/*", "Tracking/TrackSeeding/*", "Tracking/TrackBuilding/*", "Tracking/TrackConversion/*"),
     efficiency = cms.vstring(
     "effic 'Efficiency vs #eta' num_assoc(simToReco)_eta num_simul_eta",
     "efficPt 'Efficiency vs p_{T}' num_assoc(simToReco)_pT num_simul_pT",
@@ -159,7 +159,7 @@
 )
 
 postProcessorTrackSummary = cms.EDAnalyzer("DQMGenericClient",
-    subDirs = cms.untracked.vstring("Tracking/Track", "Tracking/TrackFromPV", "Tracking/TrackFromPVAllTP", "Tracking/TrackAllTPEffic", "Tracking/TrackSeeding", "Tracking/TrackBuilding"),
+    subDirs = cms.untracked.vstring("Tracking/Track", "Tracking/TrackFromPV", "Tracking/TrackFromPVAllTP", "Tracking/TrackAllTPEffic", "Tracking/TrackSeeding", "Tracking/TrackBuilding", "Tracking/TrackConversion"),
     efficiency = cms.vstring(
     "effic_vs_coll 'Efficiency vs track collection' num_assoc(simToReco)_coll num_simul_coll",
     "effic_vs_coll_allPt 'Efficiency vs track collection' num_assoc(simToReco)_coll_allPt num_simul_coll_allPt",

Validation/RecoTrack/python/TrackValidation_cff.py

@@ -13,6 +13,7 @@
 from SimTracker.TrackerHitAssociation.clusterTpAssociationProducer_cfi import *
 from SimTracker.VertexAssociation.VertexAssociatorByPositionAndTracks_cfi import *
 from PhysicsTools.RecoAlgos.trackingParticleSelector_cfi import trackingParticleSelector as _trackingParticleSelector
+from CommonTools.RecoAlgos.trackingParticleConversionSelector_cfi import trackingParticleConversionSelector as _trackingParticleConversionSelector
 from CommonTools.RecoAlgos.sortedPrimaryVertices_cfi import sortedPrimaryVertices as _sortedPrimaryVertices
 from CommonTools.RecoAlgos.recoChargedRefCandidateToTrackRefProducer_cfi import recoChargedRefCandidateToTrackRefProducer as _recoChargedRefCandidateToTrackRefProducer
 
@@ -204,6 +205,17 @@ def _addSeedToTrackProducers():
 tracksValidationSelectorsFromPV.insert(0, generalTracksFromPV)
 
 
+## Select conversion TrackingParticles, and define the corresponding associator
+# (do not use associations because the collections of interest are not subsets of each other)
+trackingParticlesConversion = _trackingParticleConversionSelector.clone()
+tpClusterProducerConversion = tpClusterProducer.clone(
+    trackingParticleSrc = "trackingParticlesConversion",
+)
+quickTrackAssociatorByHitsConversion = quickTrackAssociatorByHits.clone(
+    cluster2TPSrc = "tpClusterProducerConversion"
+)
+
+
 ## MTV instances
 trackValidator = Validation.RecoTrack.MultiTrackValidator_cfi.multiTrackValidator.clone()
 trackValidator.label = ["generalTracks", _generalTracksHp] + _selectorsByAlgo + _selectorsByAlgoHp +  [
@@ -264,6 +276,30 @@ def _addSeedToTrackProducers():
 trackValidatorAllTPEffic.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXR.signalOnly = False
 trackValidatorAllTPEffic.histoProducerAlgoBlock.TpSelectorForEfficiencyVsVTXZ.signalOnly = False
 
+# For conversions
+trackValidatorConversion = trackValidator.clone(
+    dirName = "Tracking/TrackConversion/",
+    label = [
+        "convStepTracks",
+        "conversionStepTracks",
+        "ckfInOutTracksFromConversions",
+        "ckfOutInTracksFromConversions",
+    ],
+    label_tp_effic = "trackingParticlesConversion",
+    label_tp_fake = "trackingParticlesConversion",
+    associators = ["quickTrackAssociatorByHitsConversion"],
+    UseAssociators = True,
+    doSimPlots = True,
+    dodEdxPlots = False,
+    doPVAssociationPlots = False,
+    calculateDrSingleCollection = False,
+)
+# relax lip and tip
+for n in ["Eta", "Phi", "Pt", "VTXR", "VTXZ"]:
+    pset = getattr(trackValidatorConversion.histoProducerAlgoBlock, "TpSelectorForEfficiencyVs"+n)
+    pset.lip = trackValidatorConversion.lipTP.value()
+    pset.tip = trackValidatorConversion.tipTP.value()
+
 
 # the track selectors
 tracksValidationSelectors = cms.Sequence(
@@ -287,26 +323,34 @@ def _addSeedToTrackProducers():
     trackingParticleRecoTrackAsssociationSignal
 )
 
-if eras.fastSim.isChosen():
-    tracksValidationTruth.remove(tpClusterProducer)
-    tracksValidationTruthSignal.remove(tpClusterProducerSignal)
-
+tracksValidationTruthConversion = cms.Sequence(
+    trackingParticlesConversion +
+    tpClusterProducerConversion +
+    quickTrackAssociatorByHitsConversion
+)
 
 tracksPreValidation = cms.Sequence(
     tracksValidationSelectors +
     tracksValidationSelectorsFromPV +
     tracksValidationTruth +
-    tracksValidationTruthSignal
+    tracksValidationTruthSignal +
+    tracksValidationTruthConversion
 )
 
 tracksValidation = cms.Sequence(
     tracksPreValidation +
     trackValidator +
     trackValidatorFromPV +
     trackValidatorFromPVAllTP +
-    trackValidatorAllTPEffic
+    trackValidatorAllTPEffic +
+    trackValidatorConversion
 )
 
+if eras.fastSim.isChosen():
+    tracksValidationTruth.remove(tpClusterProducer)
+    tracksValidationTruthSignal.remove(tpClusterProducerSignal)
+    tracksPreValidation.remove(tracksValidationTruthConversion)
+    tracksValidation.remove(trackValidatorConversion)
 
 ### Then define stuff for standalone mode (i.e. MTV with RECO+DIGI input)
 
@@ -330,6 +374,8 @@ def _addSeedToTrackProducers():
 )
 for _label in ["cutsRecoTracksBtvLike", "cutsRecoTracksAK4PFJets"]:
     trackValidatorAllTPEfficStandalone.label.remove(_label)
+trackValidatorConversionStandalone = trackValidatorConversion.clone()
+trackValidatorConversionStandalone.label.remove("convStepTracks")
 
 # sequences
 tracksValidationSelectorsStandalone = cms.Sequence(
@@ -341,7 +387,8 @@ def _addSeedToTrackProducers():
     trackValidatorStandalone +
     trackValidatorFromPVStandalone +
     trackValidatorFromPVAllTPStandalone +
-    trackValidatorAllTPEfficStandalone
+    trackValidatorAllTPEfficStandalone +
+    trackValidatorConversionStandalone
 )
 tracksValidationStandalone = cms.Sequence(
     ak4PFL1FastL2L3CorrectorChain +
@@ -375,6 +422,9 @@ def _addSeedToTrackProducers():
     doSeedPlots = True,
 )
 
+trackValidatorConversionTrackingOnly = trackValidatorConversion.clone()
+trackValidatorConversionTrackingOnly.label.remove("ckfInOutTracksFromConversions")
+trackValidatorConversionTrackingOnly.label.remove("ckfOutInTracksFromConversions")
 
 # sequences
 tracksPreValidationTrackingOnly = tracksPreValidation.copy()
@@ -386,6 +436,7 @@ def _addSeedToTrackProducers():
     trackValidatorSeedingTrackingOnly +
     trackValidatorBuildingTrackingOnly
 )
+trackValidatorsTrackingOnly.replace(trackValidatorConversionStandalone, trackValidatorConversionTrackingOnly)
 
 tracksValidationTrackingOnly = cms.Sequence(
     tracksPreValidationTrackingOnly +