(docs) update docs/design.md #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vladdoster
commented
Jun 19, 2021
vladdoster
commented
- update spelling
- update agreement
- correct capitalization
- remove redundancy
vladdoster
changed the title
Nuru
requested changes
Jun 19, 2021
|
I'm almost positive the Going to cross my i's and cross my t's by squashing these two additional commits. Thanks for the feedback and review! |
- update spelling - update agreement - correct capitalization - remove redundancy Signed-off-by: Vladislav Doster <[email protected]>
@vladdoster Correct, Labeler simply does not work on forks, because you do not have permission to add labels to this repo. CC: @osterman |
Nuru
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.