Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create docker image when release is published #658

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Create docker image when release is published #658

merged 3 commits into from
Dec 15, 2020

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Dec 15, 2020 •
edited
Loading

what

  • Create docker image when release is "published"

why

  • We had been creating the image when the release was "created" but we are now creating release drafts, and want to create the image when we finally publish the release. Use "release" type "published" instead of "release" so that images are built for published "pre-release" versions, too.

@Nuru Nuru requested a review from a team as a code owner December 15, 2020 00:45
@Nuru Nuru merged commit 234d8b9 into master Dec 15, 2020
@Nuru Nuru deleted the docker-tuning branch December 15, 2020 02:14
leb4r pushed a commit that referenced this pull request Jan 25, 2022
@cloudpossebot @osterman
Update codefresh to 0.73.18 → 0.73.19 (#658)
55efabf 
Co-authored-by: osterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman