Add rootfs/usr/local/bin/git-credential-github. Update rootfs/etc/init.d/atlantis.sh to use git-credential-github
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init.d/atlantis.sh` to use `git-credential-github`
osterman
requested changes
May 17, 2019
| # https://git-scm.com/book/en/v2/Git-Tools-Credential-Storage | ||
| export GITHUB_USER=${ATLANTIS_GH_USER} | ||
| export GITHUB_TOKEN=${ATLANTIS_GH_TOKEN} | ||
| git config --global credential.helper 'github' |
There was a problem hiding this comment.
I think the name of the helper should be the script name, no?
There was a problem hiding this comment.
it's the last part after git-credential-
https://git-scm.com/book/en/v2/Git-Tools-Credential-Storage
osterman
previously approved these changes
May 17, 2019
osterman
approved these changes
May 18, 2019
leb4r
pushed a commit
that referenced
this pull request
Jan 25, 2022
Co-authored-by: osterman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
rootfs/usr/local/bin/git-credential-githubrootfs/etc/init.d/atlantis.shto usegit-credential-githubwhy
git-credential-githubis useful for adding GitHub credentials togitto allow access to private GitHub reposatlantisserver starts, executegit-credential-githubto configuregitwithatlantisuser and GitHub token to allow access to private reposreferences