Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codefresh/build] Use the normalized branch name #471

Merged
merged 1 commit into from
May 6, 2019
Merged

[codefresh/build] Use the normalized branch name #471

merged 1 commit into from
May 6, 2019

Conversation

osterman
Copy link
Member

@osterman osterman commented May 6, 2019

what

  • Use the normalized branch name

why

  • Sometimes branches contain slashes or other bad characters for docker tags

@osterman osterman changed the title Use the normalized branch name [codefresh/build] Use the normalized branch name May 6, 2019
@osterman osterman requested review from aknysh and Nuru May 6, 2019 22:32
@osterman osterman merged commit 6d322d9 into master May 6, 2019
@osterman osterman deleted the cf-branch-normalized branch May 6, 2019 22:45
leb4r pushed a commit that referenced this pull request Jan 25, 2022
@cloudpossebot @osterman
Update github-commenter to 0.8.0 (#471)
62cd874 
Co-authored-by: osterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osterman @Nuru