h3: Avoid unnecessary work on control streams #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, quiche's poll() function would attempt to do work on control or QPACK streams, whether they were readable or not. Since we encourage apps to call poll() after each read loop, this could result in wasted work. With this change, we'll return early if the stream is not actually readable.
ghedo
force-pushed
the
early-exit-control-stream-processing
branch
from
44ad21f
to
cd0adbd
Compare
ghedo
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, quiche's poll() function would attempt to do work on control or
QPACK streams, whether they were readable or not. Since we encourage apps to
call poll() after each read loop, this could result in wasted work.
With this change, we'll return early if the stream is not actually readable.