h3i: initial version #1820
Merged
h3i: initial version #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 |
ghedo
requested changes
Jul 21, 2024
There was a problem hiding this comment.
Added some minor comments.
Looking at the generated docs, it looks like there are a whole bunch of public types and modules that I'm not entirely sure should actually be public as they don't seem useful to applications using h3i. Might want to go through the docs and check that the all the things that are public should be.
| name = "h3i" | ||
| version = "0.1.0" | ||
| edition = "2018" | ||
|
|
There was a problem hiding this comment.
Need to add more metadata here to be able to publish to crates.io, e.g. see https://github.com/cloudflare/quiche/blob/master/quiche/Cargo.toml and https://github.com/cloudflare/quiche/blob/master/quiche/Cargo.toml
ghedo
reviewed
Jul 21, 2024
|
All of my comments are resolved by #1822, feel free to merge that here and resolve |
ghedo
reviewed
Aug 29, 2024
Co-authored-by: Evan Rittenhouse <[email protected]>
Co-authored-by: Alessandro Ghedini <[email protected]>
* add connection_close frame to h3i * Reviewer comments * Refactor error prompts to new file
LPardue
force-pushed
the
lucas/h3i-gh
branch
from
b6c9b98
to
767974f
Compare
* Make SNI optional with --omit-sni argument * Add sensible defaults to additional HEADER prompts
ghedo
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README.md