device: use runtime instead of compile-time environment var for macos drop privileges #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…to get user In #231 we accidentally started using a compile-time environment environment variable instead of a runtime one for dropping privileges on macos. This causes privilege drops to fail when the user who is running the program does not have the same username as the user who compiled the program. The solution here is to use the runtime variable instead.
Noah-Kennedy
force-pushed
the
noah/fix-macos-drop-privileges
branch
from
ae7d6a2
to
eb6e47d
Compare
Noah-Kennedy
changed the title
agrover
approved these changes
Jul 19, 2022
Noah-Kennedy
added a commit
that referenced
this pull request
Jul 20, 2022
arvydasv
pushed a commit
to NordSecurity/boringtun
that referenced
this pull request
Aug 1, 2023
… drop privileges (cloudflare#297) In cloudflare#231 we accidentally started using a compile-time environment environment variable instead of a runtime one for dropping privileges on macos. This causes privilege drops to fail when the user who is running the program does not have the same username as the user who compiled the program. The solution here is to use the runtime variable instead.
arvydasv
pushed a commit
to NordSecurity/boringtun
that referenced
this pull request
Aug 1, 2023
…flare#298) # v0.5.2 ### Fixed - device: use runtime instead of compile-time environment var for macos drop privileges ([cloudflare#297]) [cloudflare#297]: cloudflare#297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #231 we accidentally started using a compile-time environment environment variable instead of a runtime one for dropping privileges on macos. This causes privilege drops to fail when the user who is running the program does not have the same username as the user who compiled the program.
The solution here is to use the runtime variable instead.