2018 edition #21
Merged
2018 edition #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
force-pushed
the
2018-edition
branch
from
22c85fe
to
4832fde
Compare
|
assuming this passes CI this is a good first effort at moving us to the 2018 edition, all the module system stuff is updated. there may be a few idioms that we could update but for the most part this should be good to go. |
vkrasnov
suggested changes
Mar 25, 2019
ashleygwilliams
force-pushed
the
2018-edition
branch
from
c4dd4e8
to
1a1cb4f
Compare
vkrasnov
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20