AllowedIps: Use ip_network_table instead of homegrown trie impl #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip_network_table crate is exactly what we need so use it instead of own trie impl. Big code/complexity reduction. Keep all unit tests. This in turn uses ip_network and treemap crates, these both look good too. (wireguard-rs also uses these, fwiw.) Make small changes to rest of code as needed. AllowedIps interface is mostly the same but I couldn't resist a few tweaks.
agrover
changed the title
Bren2010
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ip_network_tablecrate is exactly what we need so use it instead ofown trie impl. Big code/complexity reduction. Keep all unit tests.
This in turn uses
ip_networkandtreebitmapcrates, these bothlook good too. (wireguard-rs also uses these, fwiw.)
Make small changes to rest of code as needed. AllowedIps interface is
mostly the same but I couldn't resist a few tweaks.