Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livy:337 Binding RPCServer to user provided port and not random port #334

Merged
merged 25 commits into from
Jun 8, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
bc8f2ac
Code changes in RPCserver for user provided port
pralabhkumar May 20, 2017
968f584
Indentation Changes
pralabhkumar May 20, 2017
8e3c0ef
Indentation Changes
pralabhkumar May 20, 2017
a8c53b8
Indentation Changes
pralabhkumar May 20, 2017
94d23e5
Indentation Changes
pralabhkumar May 20, 2017
994ac16
Configuring Port Range
pralabhkumar May 21, 2017
238d238
Documentation Changed
pralabhkumar May 21, 2017
951739c
launcher.port.range will take care of launching RPC
pralabhkumar May 29, 2017
dbaf50a
Checkstyle changes
pralabhkumar May 29, 2017
4a7e219
Checkstyle changes
pralabhkumar May 29, 2017
5ac6512
Dummy push
pralabhkumar Jun 1, 2017
02c51b3
Code changes
pralabhkumar Jun 1, 2017
a2938d5
Changed BindException Handling to SocketException Handling
pralabhkumar Jun 1, 2017
e6524d4
Changed Import Order
pralabhkumar Jun 1, 2017
a6ea902
Code changes to increase port range
pralabhkumar Jun 2, 2017
789ae88
Set Port isConntect to true
pralabhkumar Jun 2, 2017
edbf6c9
Indentation Changes & port range in livy-client.conf.template
pralabhkumar Jun 5, 2017
2c4189c
Indentation changes
pralabhkumar Jun 5, 2017
2b91398
Changed visibilty of method private
pralabhkumar Jun 5, 2017
a8e29d1
Indentation Changes
pralabhkumar Jun 5, 2017
e59e9a7
Indenetation Changes
pralabhkumar Jun 5, 2017
59683d3
Unit test case to test port range
pralabhkumar Jun 7, 2017
57b6c51
Checkstyle changes
pralabhkumar Jun 7, 2017
a22222e
Unit test case for port range
pralabhkumar Jun 7, 2017
3f58233
Added comment for Port Range Configuration and increase port range fo…
pralabhkumar Jun 8, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added comment for Port Range Configuration and increase port range fo…
…r unit test case
  • Loading branch information
pralabhkumar committed Jun 8, 2017
commit 3f58233eb428b2e4183a4c87908142e12458c7d4
1 change: 1 addition & 0 deletions conf/livy-client.conf.template
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@

# Address for the RSC driver to connect back with it's connection info.
# livy.rsc.launcher.address =
# Port Range on which RPC will launch . Port range in inclusive of start and end port .
# livy.rsc.launcher.port.range = 10000~10110
Copy link
Contributor

@zjffdu zjffdu Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add one comment for this configuration, especially about whether start/end port is inclusive and exclusive

Copy link
Contributor Author

@pralabhkumar pralabhkumar Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zjffdu
done


# How long will the RSC wait for a connection for a Livy server before shutting itself down.
Expand Down
2 changes: 1 addition & 1 deletion rsc/src/test/java/com/cloudera/livy/rsc/rpc/TestRpc.java
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public void testPortRange() throws Exception {
} catch (Exception ee) {
assertTrue(ee instanceof ArrayIndexOutOfBoundsException);
}
portRange = "11000~11001";
portRange = "11000~11110";
emptyConfig.set(LAUNCHER_PORT_RANGE, portRange);
String [] portRangeData = portRange.split("~");
int startPort = Integer.parseInt(portRangeData[0]);
Expand Down