-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Livy:337 Binding RPCServer to user provided port and not random port #334
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
bc8f2ac
Code changes in RPCserver for user provided port
pralabhkumar 968f584
Indentation Changes
pralabhkumar 8e3c0ef
Indentation Changes
pralabhkumar a8c53b8
Indentation Changes
pralabhkumar 94d23e5
Indentation Changes
pralabhkumar 994ac16
Configuring Port Range
pralabhkumar 238d238
Documentation Changed
pralabhkumar 951739c
launcher.port.range will take care of launching RPC
pralabhkumar dbaf50a
Checkstyle changes
pralabhkumar 4a7e219
Checkstyle changes
pralabhkumar 5ac6512
Dummy push
pralabhkumar 02c51b3
Code changes
pralabhkumar a2938d5
Changed BindException Handling to SocketException Handling
pralabhkumar e6524d4
Changed Import Order
pralabhkumar a6ea902
Code changes to increase port range
pralabhkumar 789ae88
Set Port isConntect to true
pralabhkumar edbf6c9
Indentation Changes & port range in livy-client.conf.template
pralabhkumar 2c4189c
Indentation changes
pralabhkumar 2b91398
Changed visibilty of method private
pralabhkumar a8e29d1
Indentation Changes
pralabhkumar e59e9a7
Indenetation Changes
pralabhkumar 59683d3
Unit test case to test port range
pralabhkumar 57b6c51
Checkstyle changes
pralabhkumar a22222e
Unit test case for port range
pralabhkumar 3f58233
Added comment for Port Range Configuration and increase port range fo…
pralabhkumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Added comment for Port Range Configuration and increase port range fo…
…r unit test case
- Loading branch information
commit 3f58233eb428b2e4183a4c87908142e12458c7d4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add one comment for this configuration, especially about whether start/end port is inclusive and exclusive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zjffdu
done