Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-319. Unify the indent for all POM files #302

Merged
merged 1 commit into from
Mar 4, 2017

Conversation

ajbozarth
Copy link
Contributor

LIVY-319

Updated pom files that used 4 space indent to use 2 space indent to match the remaining pom files.

@ajbozarth
Copy link
Contributor Author

ajbozarth commented Mar 2, 2017

Not sure why the diff on GitHub is so weird, the only changes are the indent levels.

Also I believe this update makes every xml file in Livy use 2 space indent now

@jerryshao
Copy link
Contributor

LGTM, thanks for the fix.

@jerryshao
Copy link
Contributor

CC @alex-the-man

@alex-the-man alex-the-man merged commit 126b57e into cloudera:master Mar 4, 2017
@ajbozarth ajbozarth deleted the pom-dent branch March 4, 2017 00:59
@codecov-io
Copy link

Codecov Report

Merging #302 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
+ Coverage     69.75%   70.34%   +0.59%     
- Complexity      683      685       +2     
============================================
  Files            93       93              
  Lines          4843     4843              
  Branches        727      727              
============================================
+ Hits           3378     3407      +29     
+ Misses          980      949      -31     
- Partials        485      487       +2
Impacted Files Coverage Δ Complexity Δ
...in/java/com/cloudera/livy/rsc/ContextLauncher.java 80.59% <0%> (-2.49%) 19% <0%> (ø)
...ain/scala/com/cloudera/livy/sessions/Session.scala 73.33% <0%> (-1.91%) 17% <0%> (-1%)
...in/scala/com/cloudera/livy/server/LivyServer.scala 34.66% <0%> (+0.66%) 7% <0%> (ø)
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 77.58% <0%> (+1.29%) 41% <0%> (+2%)
...cala/com/cloudera/livy/repl/SparkInterpreter.scala 82.85% <0%> (+19.04%) 8% <0%> (+1%)
...m/cloudera/livy/repl/SparkContextInitializer.scala 63.15% <0%> (+21.05%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74d5a9...c8a1c69. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants