Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-315. Enable hive in SparkRInterpreter #293

Merged
merged 1 commit into from
Feb 17, 2017
Merged

LIVY-315. Enable hive in SparkRInterpreter #293

merged 1 commit into from
Feb 17, 2017

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Feb 16, 2017

livy.repl.enableHiveContext doesn't take effect in SparkRInterpreter. Fix it in this PR.

Tested it manually for both spark 1.6 and spark 2.1

@zjffdu
Copy link
Contributor Author

zjffdu commented Feb 17, 2017

@tc0312 @jerryshao Please help review. CI failure is not relevant.

[ERROR] Failed to execute goal org.jacoco:jacoco-maven-plugin:0.7.7.201606060606:report-aggregate (jacoco-report) on project livy-coverage-report: An error has occurred in JaCoCo Aggregate report generation. Error while creating report: null: EOFException -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.7.7.201606060606:report-aggregate (jacoco-report) on project livy-coverage-report: An error has occurred in JaCoCo Aggregate report generation.

@jerryshao
Copy link
Contributor

It is a jacoco issue, you could rerun again as a workaround.

@zjffdu zjffdu closed this Feb 17, 2017
@zjffdu zjffdu reopened this Feb 17, 2017
@zjffdu zjffdu closed this Feb 17, 2017
@zjffdu zjffdu reopened this Feb 17, 2017
@jerryshao
Copy link
Contributor

It's weird this jacoco failure happens quite frequently in your PR, something might be wrong. Ping @tc0312 .

@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #293 into master will increase coverage by 0.06%.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##             master     #293      +/-   ##
============================================
+ Coverage     70.57%   70.63%   +0.06%     
- Complexity      670      676       +6     
============================================
  Files            92       92              
  Lines          4812     4819       +7     
  Branches        720      723       +3     
============================================
+ Hits           3396     3404       +8     
+ Misses          927      926       -1     
  Partials        489      489
Impacted Files Coverage Δ Complexity Δ
...la/com/cloudera/livy/repl/ProcessInterpreter.scala 55.1% <ø> (-1.15%) 1 <ø> (ø)
...ala/com/cloudera/livy/repl/SparkRInterpreter.scala 64.02% <40%> (-1.39%) 2 <ø> (ø)
...in/java/com/cloudera/livy/rsc/ContextLauncher.java 80.93% <ø> (-2.12%) 19% <ø> (ø)
.../java/com/cloudera/livy/rsc/driver/JobWrapper.java 80.64% <ø> (ø) 8% <ø> (+1%)
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 78.87% <ø> (+2.58%) 42% <ø> (+3%)
.../java/com/cloudera/livy/rsc/rpc/RpcDispatcher.java 69.56% <ø> (+3.26%) 20% <ø> (+1%)
...va/com/cloudera/livy/rsc/rpc/KryoMessageCodec.java 98.11% <ø> (+3.77%) 19% <ø> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c434c...cf9f269. Read the comment docs.

@alex-the-man alex-the-man merged commit ed1c86e into cloudera:master Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants