Remove laziness in Slamhound's "get-available-classes" #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the classpath gets big enough, this would cause a stack overflow, which from clj-refactor simply shows up as a timeout. Instead use transducers over lists as much as possible. Since the collection of available classes is only ever traversed sequentially, this provides the best performance as well.
| (catch Exception e [])))) ; fail gracefully if jar is unreadable | ||
|
|
||
| (defmethod path-class-files :dir | ||
| ;; Dispatch directories and files (excluding jars) recursively. | ||
| [#^File d #^File loc] | ||
| (let [fs (.listFiles d (proxy [FilenameFilter] [] | ||
| (accept [d n] (not (jar? (file n))))))] | ||
| (reduce concat (for [f fs] (path-class-files f loc))))) |
There was a problem hiding this comment.
this line was actually asking for trouble..
|
Tests are all green, including with mranderson. Anything I can do to move this forward? Thx! |
plexus
commented
Jan 22, 2017
| (into (map #(System/getProperty %) ["sun.boot.class.path" | ||
| "java.ext.dirs" | ||
| "java.class.path"]) | ||
| (map #(.getName %) (cp/classpath-jarfiles)))) |
There was a problem hiding this comment.
I just copied this logic over, although it seems strange to me that this is really the way to get the full classpath.
|
this looks awesome @plexus. give me a few days tops to have a proper look tho |
|
actually one small thing: can you pls add a one liner to the change log? |
|
Sure thing! If it's ok I'm gonna push a few more small cleanups, like replace |
|
👍 |
FileNameFilter is an interface, so reify does the job just fine, no need for proxy.
plexus
added a commit
to plexus/refactor-nrepl
that referenced
this pull request
Jan 22, 2017
Error inherits directly from Throwable, so Errors are not Exceptions, they need to be handled separately. This category includes RuntimeError, StackOverflowError, and NoClassDefFoundError. In regular applications you would not catch these, but in our case letting them bubble means the nREPL handler dies without returning a response, causing the client to assume that the operation is taking too long and time out, without any useful feedback. This is bad UX, and it makes it hard to diagnose and debug problems like clojure-emacs#184. At least this way the user will see a stack trace that hints at the problem.
3 tasks
|
great work @plexus! thanks again for all your PRs this WE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the classpath gets big enough, this would cause a stack overflow, which
from clj-refactor simply shows up as a timeout.
Instead use transducers over lists as much as possible. Since the collection of
available classes is only ever traversed sequentially, this provides the best
performance as well.
lein do clean, test)./build.sh install-- takes a long time)Thanks!