Skip to content

Commit

Permalink
changed error threshold (fixes LxMLS#90)
Browse files Browse the repository at this point in the history
  • Loading branch information
dcferreira authored and ramon-astudillo committed Jun 11, 2018
1 parent a1bbd39 commit e9915a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions tests/test_non_linear_classifiers_numpy.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
from lxmls.deep_learning.numpy_models.mlp import NumpyMLP
from lxmls.deep_learning.mlp import get_mlp_parameter_handlers, get_mlp_loss_range

tolerance = 2 #TODO #FIXME Implementations give random results in a +-1 margin.
# Check the source of this randomness
tolerance = 1e-2

@pytest.fixture(scope='module')
def corpus():
Expand Down
3 changes: 1 addition & 2 deletions tests/test_non_linear_classifiers_pytorch.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
from lxmls.deep_learning.utils import Model, glorot_weight_init
from lxmls.deep_learning.pytorch_models.mlp import PytorchMLP

tolerance = 2 #TODO #FIXME: Pytorch gives random results in a +-2 margin.
# Check the source of this randomness
tolerance = 1e-2


@pytest.fixture(scope='module')
Expand Down

0 comments on commit e9915a2

Please sign in to comment.