Add prometheus-operator app #7
Conversation
|
I might add, this is still WIP as I did not get a working installation as I believe I have issues on my cluster. |
There was a problem hiding this comment.
Other than setting it to a version where possible and adding the uninstall.sh, it's all good for me.
A better way might be to download those YAML files, concatenate them in to a single app.yaml and then it's easy to unapply the same file, then run the uninstall.sh (or just run the uninstall.sh?).
prometheus-operator/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| uninstall.sh | |||
There was a problem hiding this comment.
If you have an uninstall.sh (that takes no parameters), please feel free to commit it - this is exactly the mechanism we are going to be using to uninstall applications, other than just reversing the kubectl apply -f app.yaml if one exists.
prometheus-operator/install.sh
Outdated
| kubectl apply -f https://raw.githubusercontent.com/coreos/prometheus-operator/master/example/prometheus-operator-crd/prometheus.crd.yaml | ||
| kubectl apply -f https://raw.githubusercontent.com/coreos/prometheus-operator/master/example/prometheus-operator-crd/prometheusrule.crd.yaml | ||
| kubectl apply -f https://raw.githubusercontent.com/coreos/prometheus-operator/master/example/prometheus-operator-crd/servicemonitor.crd.yaml | ||
| kubectl apply -f https://raw.githubusercontent.com/coreos/prometheus-operator/master/example/prometheus-operator-crd/podmonitor.crd.yaml |
There was a problem hiding this comment.
These should at least use versions of these files from a commit/release. Otherwise we have an unstable application in the marketplace (something breaks on master, customers install it here and it doesn't work, etc).
| --name prometheus-operator \ | ||
| --namespace ${NAMESPACE} \ | ||
| --set prometheusOperator.createCustomResource=false \ | ||
| stable/prometheus-operator |
There was a problem hiding this comment.
Likewise is there a way of using a particular version? I know it means maintenance work when it's time to upgrade, but at least it means we have a tested/known-working version.
prometheus-operator/manifest.yaml
Outdated
| --- | ||
| name: prometheus-operator | ||
| title: "Prometheus Operator" | ||
| version: Stable |
There was a problem hiding this comment.
As above - version locking :-)
* The configuration for the prometheus-operator may change based on the cluster size, I could look in to what the posibilities are now or for a future version.
As requested addressed. Wasn't sure about the version as I can lock the helm chart version, not the app version. Or do we have a way of locking to the specific app version we want to install with helm (I don't have that much experience with helm)? |
|
That's completely fine as you've done. We've not hopefully got a static version that should always work (may need upgrading, but less chance of it unexpectedly breaking one day). I'll merge it in. Just for next time, we tend to give about 10% total padding around the logos (e.g. 5% of image width either side). We go by feel, but that's a good starting point. I'll adjust the logo after merge. Thanks for doing this :-) |
cluster size, I could look in to what the posibilities are now or for a
future version.