Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubefirst marketplace helm install, description, and image adjustments #466

Merged
merged 14 commits into from
Jul 22, 2023

Conversation

johndietz
Copy link
Contributor

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!

If your pull request is to submit a new application to the marketplace, please answer the following questions:

  • Have you followed the guidelines in our Contributing document in setting up the application?
  • Have you checked that the application your submission is proposing to add does not yet exist on the Marketplace, or as a pull request to be processed?
  • Have you tested your application on the Civo managed Kubernetes service? Please include a screenshot.
  • Can you confirm that the software you are submitting licensed for use in a publicly-available Kubernetes marketplace?
  • Have you included the specific version of the application to be installed?

If your pull request concerns an existing Marketplace application, please make sure you have:

  • Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
  • Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
  • Tested that the application works with the proposed updates applied (including a screenshot).
  • Updated the version number of the app if that has changed.

@saiyam1814
Copy link
Contributor

@johndietz Can you please confirm if the logo is square?

@johndietz
Copy link
Contributor Author

@saiyam1814 - logo.png has been updated to a square ratio with transparent padding. thanks for the 👀 !

@saiyam1814
Copy link
Contributor

@saiyam1814 - logo.png has been updated to a square ratio with transparent padding. thanks for the 👀 !

@johndietz its bigger in size
as per readme
a square aspect ratio logo.png no smaller than 80x80, no larger than 512x512 and no bigger than 20KB

@johndietz
Copy link
Contributor Author

darn it - sorry about that saiyam, changed to a downres image that's only 13k, ratio squared at 373x373. thanks so much for the extra cycle.

Copy link
Contributor

@saiyam1814 saiyam1814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saiyam1814 saiyam1814 merged commit a9f4b3d into civo:master Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants