Remove password hash #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash is no-longer required due to the creation using an environment variable instead of a YAML file. The post-install instructions are also updated to mention the password being in the UI and the NodePort being used. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
openfaas/post_install.md
Outdated
|
|
||
| * B) Get your kubeconfig via the Dashboard | ||
|
|
||
| * Either download your `kubeconfig` file from the Civo dashboard. |
There was a problem hiding this comment.
This "Either" isn't right when it's the second option and the first was already given?
openfaas/post_install.md
Outdated
| @@ -27,7 +45,13 @@ export KUBECONFIG=$HOME/Downloads/config-file.yaml | |||
|
|
|||
| ### Find your generated password | |||
|
|
|||
| Now retrieve your password from above and save it into a file called `password.txt`. | |||
| You can find your password in the Civo Dashboard by clicking on the OpenFaaS application and save it as `password.txt`. | |||
There was a problem hiding this comment.
You don't need to say "You can find your password in the Civo Dashboard by clicking on the OpenFaaS application" because this is inherently only displayed in the Civo Dashboard, when they have already clicked the installed OpenFaaS application. That's why I changed it to "from above".
There was a problem hiding this comment.
No problem. I thought you may use this text in other places, like the CLI.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
PR updated for your comments |
DMajrekar
pushed a commit
that referenced
this pull request
Nov 2, 2023
version bump helm chart 2.1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash is no-longer required due to the creation using an
environment variable instead of a YAML file.
The post-install instructions are also updated to mention
the password being in the UI and the NodePort being used.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]