Skip to content

Commit

Permalink
arm64: mte: Fix double-freeing of the temporary tag storage during co…
Browse files Browse the repository at this point in the history
…redump

Commit 16decce ("arm64: mte: Fix the stack frame size warning in
mte_dump_tag_range()") moved the temporary tag storage array from the
stack to slab but it also introduced an error in double freeing this
object. Remove the in-loop freeing.

Fixes: 16decce ("arm64: mte: Fix the stack frame size warning in mte_dump_tag_range()")
Cc: <[email protected]> # 5.18.x
Signed-off-by: Catalin Marinas <[email protected]>
Reported-by: Seth Jenkins <[email protected]>
Cc: Will Deacon <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Will Deacon <[email protected]>
  • Loading branch information
ctmarinas authored and willdeacon committed Jan 5, 2023
1 parent eb9a852 commit 736eedc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/arm64/kernel/elfcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ static int mte_dump_tag_range(struct coredump_params *cprm,
mte_save_page_tags(page_address(page), tags);
put_page(page);
if (!dump_emit(cprm, tags, MTE_PAGE_TAG_STORAGE)) {
mte_free_tag_storage(tags);
ret = 0;
break;
}
Expand Down

0 comments on commit 736eedc

Please sign in to comment.