Rule update to only fire for in-scope assets

chudson121 · Nov 14, 2020 · cec241a · cec241a
1 parent 514b312
commit cec241a
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/risks/built-in/incomplete-model/incomplete-model-rule.go b/risks/built-in/incomplete-model/incomplete-model-rule.go
@@ -34,12 +34,14 @@ func GenerateRisks() []model.Risk {
 	risks := make([]model.Risk, 0)
 	for _, id := range model.SortedTechnicalAssetIDs() {
 		technicalAsset := model.ParsedModelRoot.TechnicalAssets[id]
-		if technicalAsset.Technology == model.UnknownTechnology {
-			risks = append(risks, createRiskTechAsset(technicalAsset))
-		}
-		for _, commLink := range technicalAsset.CommunicationLinks {
-			if commLink.Protocol == model.UnknownProtocol {
-				risks = append(risks, createRiskCommLink(technicalAsset, commLink))
+		if !technicalAsset.OutOfScope {
+			if technicalAsset.Technology == model.UnknownTechnology {
+				risks = append(risks, createRiskTechAsset(technicalAsset))
+			}
+			for _, commLink := range technicalAsset.CommunicationLinks {
+				if commLink.Protocol == model.UnknownProtocol {
+					risks = append(risks, createRiskCommLink(technicalAsset, commLink))
+				}
 			}
 		}
 	}