Fix mistranslation from HGVS to vcf variant #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 33.48% 33.45% -0.03%
==========================================
Files 12 12
Lines 1126 1127 +1
Branches 32 32
==========================================
Hits 377 377
- Misses 717 718 +1
Partials 32 32
Continue to review full report at Codecov.
|
totakke
approved these changes
Jan 30, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the
hgvs-to-vcftranslation of protein HGVS input and adds refseq ID into the results.There are cases where it mistranslates HGVS for minus strand gene's mutations (e.g. ALK L1196M). I fixed the minor bug and add tests.