Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse scores and exon-frames in refGene.txt #3

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Conversation

alumi
Copy link
Member

@alumi alumi commented Dec 14, 2017

I think it's better to parse score and exon-frames in refGene.txt.
If you're intentionally leaving these fields unparsed for performance reason or something, please ignore this PR.

Thank you.

@codecov
Copy link

codecov bot commented Dec 14, 2017

Codecov Report

Merging #3 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   33.75%   33.87%   +0.11%     
==========================================
  Files          12       12              
  Lines        1108     1110       +2     
  Branches       32       32              
==========================================
+ Hits          374      376       +2     
  Misses        702      702              
  Partials       32       32
Impacted Files Coverage Δ
src/varity/ref_gene.clj 63.97% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fab17b...fdd24e2. Read the comment docs.

@totakke
Copy link
Member

totakke commented Dec 14, 2017

No, there are no apparent reason for it. Maybe it's because those fields are not used in varity. You're right.

@totakke totakke merged commit 81f6cd7 into master Dec 14, 2017
@totakke totakke deleted the fix/ref-gene-parsing branch December 14, 2017 08:44
@alumi
Copy link
Member Author

alumi commented Dec 14, 2017

Thank you for merging! 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants