Throw ex-info on hgvs->vcf for a variant containing ambiguous coordinates #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current hgvs->vcf throws NPE when a variant containing ambiguous coordinates is supplied.
NM_007294:c.1-?_80+?del
is totally correct as a coding DNA HGVS, but itcannot be converted to a VCF variant because genomic positions are underspecified.
I modified cds-coord->genomic-pos to throw ex-info with
:ambiguous-coordinate
error type when such a coordinate is passed.
This patch is useful for error handling on hgvs->vcf.
And besides, I removed oraclejdk from CI because they cause build failure (Build #229).
That may be resolved if using Trusty instead of Xenial, but I think only tests with OpenJDK are enough for this library.
I confirmed
lein test :all
passed.