Feature/nonimage thumbnail

[choonkeat]

Sample rendering of png, pdf, xlsx and zip files

• images are resized like normal behavior
• pdf cover page is rendered as image, inside a polaroid, with the filename as caption
• other files are rendered as text (stating the file extension), inside a polaroid, with the filename as caption
• note that as per normal, attache returns the original file, unmodified, whenever we use original geometry string in the url

this behavior is useful in apps, since we can just upload files and use <img src=...> directly without special code.

[winston]

Some questions

filename as caption

What happens if the filename is long? Will the polaroid look ugly?

polaroid

From a design perspective, not sure if this is desirable, because then normal images are not polaroid-ed and doesn't have the shadow, while others are polaroid-ed and have the shadow. If I want to achieve consistency, then I can't really get rid of the shadow because it's already part of the image. Right?

PREVIEW_SIZE = ENV.fetch('PREVIEW_SIZE', '96x')

Also, the thumbnail size for non images are fixed? Meaning I can't specify it from <img src right?

[choonkeat]

What happens if the filename is long? Will the polaroid look ugly?

it wraps.

From a design perspective, not sure if this is desirable, because then normal images are not polaroid-ed and doesn't have the shadow, while others are polaroid-ed and have the shadow. If I want to achieve consistency, then I can't really get rid of the shadow because it's already part of the image. Right?

Correct. I'd change it to a more minimal "file icon" look if I can just sort out the commands :-P otherwise, maybe i'll just introduce black/white border (it is ultimately still a styled image, albeit minimally so)

Also, the thumbnail size for non images are fixed? Meaning I can't specify it from <img src right?

Correct. Though the file extension icons wouldn't look good

[choonkeat]

lighter colors, fixed difference of width between pdf and other file icons

[winston]

👍

[choonkeat]

@winston note that this join fixes the problem of attache server hanging

• in the Thread.new code above, we do queue << ... and then the thread exits
• but the processing of queue.pop could happen before the thread exits
• thus, break unless threads.any?(&:alive?) incorrectly account for the soon-to-be-exited thread
• the fix is to explicitly join that thread, before we check threads.any?(&:alive?)

[winston]

Oooh. http://ruby-doc.org/core-1.9.3/Thread.html#method-i-join

[choonkeat]

background: my own app uses the dynamic image/resizing features as well as the document/file storage features. when users upload documents alongside images, the resized images shows up nicely but document files are presented as icons.

@abitdodgy since your work revolves around just document and file storage, I was wondering if you'd care to chime in on such a feature (for an image server)