Add "BACKUP_ASYNC" env flag

README.md

@@ -186,6 +186,8 @@ The `paths` value should be delimited by the newline character, aka `\n`. In the
 
 If backup remote storage is not configured, this API call will be a noop. If configured, the backup storage must be accessible by the same credentials as default cloud storage as the system. Please refer to the `BACKUP_CONFIG` configuration illustrated in `config/vhost.example.yml` file in this repository.
 
+By default, `backup` operation is performed synchronously. Set `BACKUP_ASYNC` environment variable to make it follow the same synchronicity as `delete`
+
 The main reason to configure a backup storage is to make the default cloud storage auto expire files; mitigating [abuse](https://github.com/choonkeat/attache/issues/13). You should consult the documentation of your cloud storage provider on how to setup auto expiry, e.g. [here](https://aws.amazon.com/blogs/aws/amazon-s3-object-expiration/) or [here](https://cloud.google.com/storage/docs/lifecycle)
 
 ## License

lib/attache/backup.rb

@@ -10,12 +10,11 @@ def _call(env, config)
       params   = request.params
       return config.unauthorized unless config.authorized?(params)
 
-      params['paths'].to_s.split("\n").each do |relpath|
-        Attache.logger.info "CONFIRM local #{relpath}"
-        cachekey = File.join(request_hostname(env), relpath)
-        if config.storage && config.bucket
-          Attache.logger.info "CONFIRM remote #{relpath}"
-          config.async(:backup_file, relpath: relpath)
+      if config.storage && config.bucket
+        sync_method = (ENV['BACKUP_ASYNC'] ? :async : :send)
+        params['paths'].to_s.split("\n").each do |relpath|
+          Attache.logger.info "BACKUP remote #{relpath}"
+          config.send(sync_method, :backup_file, relpath: relpath)
         end
       end
       [200, config.headers_with_cors, []]

spec/lib/attache/backup_spec.rb

@@ -43,16 +43,14 @@
       end
 
       it 'should backup file' do
-        expect_any_instance_of(Attache::VHost).to receive(:async) do |instance, method, path|
-          expect(method).to eq(:backup_file)
-        end.exactly(2).times
+        expect_any_instance_of(Attache::VHost).to receive(:backup_file).exactly(2).times
         subject.call
       end
     end
 
     context 'storage NOT configured' do
       it 'should backup file' do
-        expect_any_instance_of(Attache::VHost).not_to receive(:async)
+        expect_any_instance_of(Attache::VHost).not_to receive(:backup_file)
         subject.call
       end
     end