Skip to content

Commit

Permalink
[PATCH] ppc64 kprobes: remove spurious MSR_SE masking
Browse files Browse the repository at this point in the history
Remove spurious MSR_SE reset during kprobe processing.
single_step_exception() already does it for us.  Reset it to be safe when
executing the fault_handler.

Signed-off-by: Ananth N Mavinakayanahalli <[email protected]>
Signed-off-by: Paul Mackerras <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Ananth N Mavinakayanahalli authored and Linus Torvalds committed Jun 8, 2005
1 parent 63224d1 commit f829fd2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/ppc64/kernel/kprobes.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ static void resume_execution(struct kprobe *p, struct pt_regs *regs)
ret = emulate_step(regs, p->ainsn.insn[0]);
if (ret == 0)
regs->nip = (unsigned long)p->addr + 4;

regs->msr &= ~MSR_SE;
}

static inline int post_kprobe_handler(struct pt_regs *regs)
Expand Down Expand Up @@ -215,6 +213,7 @@ static inline int kprobe_fault_handler(struct pt_regs *regs, int trapnr)

if (kprobe_status & KPROBE_HIT_SS) {
resume_execution(current_kprobe, regs);
regs->msr &= ~MSR_SE;
regs->msr |= kprobe_saved_msr;

unlock_kprobes();
Expand Down

0 comments on commit f829fd2

Please sign in to comment.