Skip to content

Commit

Permalink
slab allocators: remove multiple alignment specifications
Browse files Browse the repository at this point in the history
It is not necessary to tell the slab allocators to align to a cacheline
if an explicit alignment was already specified. It is rather confusing
to specify multiple alignments.

Make sure that the call sites only use one form of alignment.

Signed-off-by: Christoph Lameter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Christoph Lameter authored and Linus Torvalds committed May 7, 2007
1 parent 0a31bd5 commit f0f3980
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/powerpc/mm/hugetlbpage.c
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ static int __init hugetlbpage_init(void)
huge_pgtable_cache = kmem_cache_create("hugepte_cache",
HUGEPTE_TABLE_SIZE,
HUGEPTE_TABLE_SIZE,
SLAB_HWCACHE_ALIGN,
0,
zero_ctor, NULL);
if (! huge_pgtable_cache)
panic("hugetlbpage_init(): could not create hugepte cache\n");
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/mm/init_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ void pgtable_cache_init(void)
"for size: %08x...\n", name, i, size);
pgtable_cache[i] = kmem_cache_create(name,
size, size,
SLAB_HWCACHE_ALIGN,
0,
zero_ctor,
NULL);
if (! pgtable_cache[i])
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc64/mm/tsb.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ void __init pgtable_cache_init(void)

tsb_caches[i] = kmem_cache_create(name,
size, size,
SLAB_HWCACHE_ALIGN,
0,
NULL, NULL);
if (!tsb_caches[i]) {
prom_printf("Could not create %s cache\n", name);
Expand Down

0 comments on commit f0f3980

Please sign in to comment.