Skip to content

Commit

Permalink
fs/sysv: remove another useless write_super call
Browse files Browse the repository at this point in the history
We do not need to call 'sysv_write_super()' from 'sysv_remount()',
because VFS has called 'sysv_sync_fs()' before calling '->remount()'.
So remove it. Remove also '(un)lock_super()' which obvioulsy is becoming
useless in this function.

Signed-off-by: Artem Bityutskiy <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
dedekind authored and Al Viro committed Jul 22, 2012
1 parent a4d05d3 commit eee4589
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions fs/sysv/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,9 @@ static void sysv_write_super(struct super_block *sb)
static int sysv_remount(struct super_block *sb, int *flags, char *data)
{
struct sysv_sb_info *sbi = SYSV_SB(sb);
lock_super(sb);

if (sbi->s_forced_ro)
*flags |= MS_RDONLY;
if (*flags & MS_RDONLY)
sysv_write_super(sb);
unlock_super(sb);
return 0;
}

Expand Down

0 comments on commit eee4589

Please sign in to comment.