Skip to content

Commit

Permalink
nubus: Kill nubus_proc_detach_device()
Browse files Browse the repository at this point in the history
Commit 59d8053 ("proc: Move non-public
stuff from linux/proc_fs.h to fs/proc/internal.h") broke Apple NuBus
support:

drivers/nubus/proc.c: In function ‘nubus_proc_detach_device’:
drivers/nubus/proc.c:156: error: dereferencing pointer to incomplete type
drivers/nubus/proc.c:158: error: dereferencing pointer to incomplete type

Fortunately nubus_proc_detach_device() is unused, and appears to have never
been used, so just remove it.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
geertu authored and Al Viro committed May 4, 2013
1 parent 60b7bf4 commit e765acb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
15 changes: 0 additions & 15 deletions drivers/nubus/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,21 +147,6 @@ int nubus_proc_attach_device(struct nubus_dev *dev)
}
EXPORT_SYMBOL(nubus_proc_attach_device);

/* FIXME: this is certainly broken! */
int nubus_proc_detach_device(struct nubus_dev *dev)
{
struct proc_dir_entry *e;

if ((e = dev->procdir)) {
if (atomic_read(&e->count))
return -EBUSY;
remove_proc_entry(e->name, proc_bus_nubus_dir);
dev->procdir = NULL;
}
return 0;
}
EXPORT_SYMBOL(nubus_proc_detach_device);

/*
* /proc/nubus stuff
*/
Expand Down
1 change: 0 additions & 1 deletion include/linux/nubus.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ static inline void nubus_proc_init(void) {}
#endif
int get_nubus_list(char *buf);
int nubus_proc_attach_device(struct nubus_dev *dev);
int nubus_proc_detach_device(struct nubus_dev *dev);
/* If we need more precision we can add some more of these */
struct nubus_dev* nubus_find_device(unsigned short category,
unsigned short type,
Expand Down

0 comments on commit e765acb

Please sign in to comment.