Skip to content

Commit

Permalink
crypto: omap-sham - Use pm_runtime_put instead of pm_runtime_put_sync…
Browse files Browse the repository at this point in the history
… in tasklet

After DMA is complete, the omap_sham_finish_req function is called as
a part of the done_task tasklet. During this its atomic and any calls
to pm functions should not assume they wont sleep.

The patch replaces a call to pm_runtime_put_sync (which can sleep) with
pm_runtime_put thus fixing a kernel panic observed on AM33xx SoC during
SHA operation.

Tested on an AM33xx SoC device (beaglebone board).
To reproduce the problem, used the tcrypt kernel module as:
modprobe tcrypt sec=2 mode=403

Signed-off-by: Joel A Fernandes <[email protected]>
Cc: David S. Miller <[email protected]>
Acked-by: Mark A. Greer <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
Joel A Fernandes authored and herbertx committed Mar 10, 2013
1 parent fb1dd79 commit e68af48
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/crypto/omap-sham.c
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ static void omap_sham_finish_req(struct ahash_request *req, int err)
dd->flags &= ~(BIT(FLAGS_BUSY) | BIT(FLAGS_FINAL) | BIT(FLAGS_CPU) |
BIT(FLAGS_DMA_READY) | BIT(FLAGS_OUTPUT_READY));

pm_runtime_put_sync(dd->dev);
pm_runtime_put(dd->dev);

if (req->base.complete)
req->base.complete(&req->base, err);
Expand Down

0 comments on commit e68af48

Please sign in to comment.