Skip to content

Commit

Permalink
menuconfig: wrap long help lines
Browse files Browse the repository at this point in the history
Help text for certain config options is very extensive (the text
includes the names of all  other options the option in question depends
on). Long lines are not wrapped, making it impossible to see the list
without scrolling horizontally.

This patch adds some logic which wraps help screen lines at word
boundaries to prevent truncating.

Tested by running

  ARCH=powerpc make menuconfig O=/tmp/build

which shows that the long lines are now wrapped, and

 ARCH=powerpc make xconfig O=/tmp/build

to demonstrate that it still compiles and operates as expected.

Signed-off-by: Vadim Bendebury <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
  • Loading branch information
Vadim Bendebury (вб) authored and michal42 committed Feb 2, 2010
1 parent 5358db0 commit da60fbb
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 2 deletions.
27 changes: 25 additions & 2 deletions scripts/kconfig/expr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1097,9 +1097,32 @@ void expr_fprint(struct expr *e, FILE *out)

static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
{
str_append((struct gstr*)data, str);
struct gstr *gs = (struct gstr*)data;
const char *sym_str = NULL;

if (sym)
sym_str = sym_get_string_value(sym);

if (gs->max_width) {
unsigned extra_length = strlen(str);
const char *last_cr = strrchr(gs->s, '\n');
unsigned last_line_length;

if (sym_str)
extra_length += 4 + strlen(sym_str);

if (!last_cr)
last_cr = gs->s;

last_line_length = strlen(gs->s) - (last_cr - gs->s);

if ((last_line_length + extra_length) > gs->max_width)
str_append(gs, "\\\n");
}

str_append(gs, str);
if (sym)
str_printf((struct gstr*)data, " [=%s]", sym_get_string_value(sym));
str_printf(gs, " [=%s]", sym_str);
}

void expr_gstr_print(struct expr *e, struct gstr *gs)
Expand Down
5 changes: 5 additions & 0 deletions scripts/kconfig/lkc.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,11 @@ int file_write_dep(const char *name);
struct gstr {
size_t len;
char *s;
/*
* when max_width is not zero long lines in string s (if any) get
* wrapped not to exceed the max_width value
*/
int max_width;
};
struct gstr str_new(void);
struct gstr str_assign(const char *s);
Expand Down
1 change: 1 addition & 0 deletions scripts/kconfig/mconf.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,7 @@ static void show_help(struct menu *menu)
{
struct gstr help = str_new();

help.max_width = getmaxx(stdscr) - 10;
menu_get_ext_help(menu, &help);

show_helptext(_(menu_get_prompt(menu)), str_get(&help));
Expand Down
2 changes: 2 additions & 0 deletions scripts/kconfig/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ struct gstr str_new(void)
struct gstr gs;
gs.s = malloc(sizeof(char) * 64);
gs.len = 64;
gs.max_width = 0;
strcpy(gs.s, "\0");
return gs;
}
Expand All @@ -88,6 +89,7 @@ struct gstr str_assign(const char *s)
struct gstr gs;
gs.s = strdup(s);
gs.len = strlen(s) + 1;
gs.max_width = 0;
return gs;
}

Expand Down

0 comments on commit da60fbb

Please sign in to comment.