Skip to content

Commit

Permalink
Make various things static
Browse files Browse the repository at this point in the history
Building an allnoconfig kernel, sparse asked whether these could be
static, so I checked, and they are only used in the file where they are
declared.

Signed-off-by: Roel Kluin <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
RoelKluin authored and torvalds committed Jan 8, 2009
1 parent 9a8d5bb commit da2bdf9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/char/pty.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

/* These are global because they are accessed in tty_io.c */
#ifdef CONFIG_UNIX98_PTYS
struct tty_driver *ptm_driver;
static struct tty_driver *ptm_driver;
static struct tty_driver *pts_driver;
#endif

Expand Down
3 changes: 1 addition & 2 deletions drivers/char/vt.c
Original file line number Diff line number Diff line change
Expand Up @@ -969,8 +969,7 @@ int vc_resize(struct vc_data *vc, unsigned int cols, unsigned int rows)
* Takes the console sem and the called methods then take the tty
* termios_mutex and the tty ctrl_lock in that order.
*/

int vt_resize(struct tty_struct *tty, struct winsize *ws)
static int vt_resize(struct tty_struct *tty, struct winsize *ws)
{
struct vc_data *vc = tty->driver_data;
int ret;
Expand Down
6 changes: 3 additions & 3 deletions drivers/firmware/memmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ struct memmap_attribute {
ssize_t (*show)(struct firmware_map_entry *entry, char *buf);
};

struct memmap_attribute memmap_start_attr = __ATTR_RO(start);
struct memmap_attribute memmap_end_attr = __ATTR_RO(end);
struct memmap_attribute memmap_type_attr = __ATTR_RO(type);
static struct memmap_attribute memmap_start_attr = __ATTR_RO(start);
static struct memmap_attribute memmap_end_attr = __ATTR_RO(end);
static struct memmap_attribute memmap_type_attr = __ATTR_RO(type);

/*
* These are default attributes that are added for every memmap entry.
Expand Down

0 comments on commit da2bdf9

Please sign in to comment.