Skip to content

Commit

Permalink
x86,objtool: Explicitly mark idtentry_body()s tail REACHABLE
Browse files Browse the repository at this point in the history
Objtool can figure out that some \cfunc()s are noreturn and then
complains about certain instances having unreachable tails:

  vmlinux.o: warning: objtool: asm_exc_xen_unknown_trap()+0x16: unreachable instruction

Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Acked-by: Josh Poimboeuf <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
Peter Zijlstra committed Apr 19, 2022
1 parent d4e5268 commit d66e9d5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/x86/entry/entry_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,9 @@ SYM_CODE_END(ret_from_fork)

call \cfunc

/* For some configurations \cfunc ends up being a noreturn. */
REACHABLE

jmp error_return
.endm

Expand Down

0 comments on commit d66e9d5

Please sign in to comment.