Skip to content

Commit

Permalink
ACPI / hotplug / PCI: Do not pass ACPI handle to hotplug_event()
Browse files Browse the repository at this point in the history
Since hotplug_event() can get the ACPI handle needed for debug
printouts from its context argument, there's no need to pass the
handle to it.  Moreover, the second argument's type may be changed
to (struct acpiphp_context *), because that's what is always passed
to hotplug_event() as the second argument anyway.

Signed-off-by: Rafael J. Wysocki <[email protected]>
Tested-by: Mika Westerberg <[email protected]>
  • Loading branch information
rafaeljw committed Feb 5, 2014
1 parent 1d4a5b6 commit d3a1ebb
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/pci/hotplug/acpiphp_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static DEFINE_MUTEX(acpiphp_context_lock);
static void handle_hotplug_event(acpi_handle handle, u32 type, void *data);
static void acpiphp_sanitize_bus(struct pci_bus *bus);
static void acpiphp_set_hpp_values(struct pci_bus *bus);
static void hotplug_event(acpi_handle handle, u32 type, void *data);
static void hotplug_event(u32 type, struct acpiphp_context *context);
static void free_bridge(struct kref *kref);

static void acpiphp_context_handler(acpi_handle handle, void *context)
Expand Down Expand Up @@ -225,7 +225,7 @@ static void dock_event(acpi_handle handle, u32 type, void *data)
acpiphp_put_context(context);
mutex_unlock(&acpiphp_context_lock);

hotplug_event(handle, type, data);
hotplug_event(type, context);

put_bridge(context->func.parent);
}
Expand Down Expand Up @@ -813,9 +813,9 @@ void acpiphp_check_host_bridge(acpi_handle handle)

static int acpiphp_disable_and_eject_slot(struct acpiphp_slot *slot);

static void hotplug_event(acpi_handle handle, u32 type, void *data)
static void hotplug_event(u32 type, struct acpiphp_context *context)
{
struct acpiphp_context *context = data;
acpi_handle handle = context->adev->handle;
struct acpiphp_func *func = &context->func;
struct acpiphp_slot *slot = func->slot;
struct acpiphp_bridge *bridge;
Expand Down Expand Up @@ -870,14 +870,14 @@ static void hotplug_event(acpi_handle handle, u32 type, void *data)
static void hotplug_event_work(void *data, u32 type)
{
struct acpiphp_context *context = data;
acpi_handle handle = context->adev->handle;

acpi_scan_lock_acquire();

hotplug_event(handle, type, context);
hotplug_event(type, context);

acpi_scan_lock_release();
acpi_evaluate_hotplug_ost(handle, type, ACPI_OST_SC_SUCCESS, NULL);
acpi_evaluate_hotplug_ost(context->adev->handle, type,
ACPI_OST_SC_SUCCESS, NULL);
put_bridge(context->func.parent);
}

Expand Down

0 comments on commit d3a1ebb

Please sign in to comment.