cxl_getfile(): fix double-iput() on alloc_file() failures

Doing iput() after path_put() is wrong. Cc: [email protected] Acked-by: Linus Torvalds <[email protected]> Signed-off-by: Al Viro <[email protected]>
chewitt · Jul 11, 2018 · d202797 · d202797
1 parent b4e7a7a
commit d202797
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
@@ -103,15 +103,15 @@ static struct file *cxl_getfile(const char *name,
 	d_instantiate(path.dentry, inode);
 
 	file = alloc_file(&path, OPEN_FMODE(flags), fops);
-	if (IS_ERR(file))
-		goto err_dput;
+	if (IS_ERR(file)) {
+		path_put(&path);
+		goto err_fs;
+	}
 	file->f_flags = flags & (O_ACCMODE | O_NONBLOCK);
 	file->private_data = priv;
 
 	return file;
 
-err_dput:
-	path_put(&path);
 err_inode:
 	iput(inode);
 err_fs: