Skip to content

Commit

Permalink
Migrate vector timers to new timer API
Browse files Browse the repository at this point in the history
The patches for the UML vector drivers were in-flight when
the timer changes happened and were not covered by them.

This change migrates vector_kern.c to use the new timer API.

Signed-off-by: Anton Ivanov <[email protected]>
Signed-off-by: Richard Weinberger <[email protected]>
  • Loading branch information
Anton Ivanov authored and richardweinberger committed Mar 29, 2018
1 parent 530ba6c commit ce471fd
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions arch/um/drivers/vector_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -1233,9 +1233,6 @@ static int vector_net_open(struct net_device *dev)
if ((vp->options & VECTOR_BPF) != 0)
vp->bpf = uml_vector_default_bpf(vp->fds->rx_fd, dev->dev_addr);

/* Write Timeout Timer */

vp->tl.data = (unsigned long) vp;
netif_start_queue(dev);

/* clear buffer - it can happen that the host side of the interface
Expand Down Expand Up @@ -1409,9 +1406,9 @@ static const struct net_device_ops vector_netdev_ops = {
};


static void vector_timer_expire(unsigned long _conn)
static void vector_timer_expire(struct timer_list *t)
{
struct vector_private *vp = (struct vector_private *)_conn;
struct vector_private *vp = from_timer(vp, t, tl);

vp->estats.tx_kicks++;
vector_send(vp->tx_queue);
Expand Down Expand Up @@ -1500,9 +1497,8 @@ static void vector_eth_configure(
tasklet_init(&vp->tx_poll, vector_tx_poll, (unsigned long)vp);
INIT_WORK(&vp->reset_tx, vector_reset_tx);

init_timer(&vp->tl);
timer_setup(&vp->tl, vector_timer_expire, 0);
spin_lock_init(&vp->lock);
vp->tl.function = vector_timer_expire;

/* FIXME */
dev->netdev_ops = &vector_netdev_ops;
Expand Down

0 comments on commit ce471fd

Please sign in to comment.