Skip to content

Commit

Permalink
kernel: Fix sparse warning for ACCESS_ONCE
Browse files Browse the repository at this point in the history
Commit 927609d ("kernel: tighten rules for ACCESS ONCE") results in
sparse warnings like "Using plain integer as NULL pointer" - Let's add a
type cast to the dummy assignment.
To avoid warnings lik "sparse: warning: cast to restricted __hc32" we also
use __force on that cast.

Fixes: 927609d ("kernel: tighten rules for ACCESS ONCE")
Signed-off-by: Christian Borntraeger <[email protected]>
  • Loading branch information
borntraeger committed Jan 19, 2015
1 parent 378af02 commit c5b1994
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ static __always_inline void __assign_once_size(volatile void *p, void *res, int
* If possible use READ_ONCE/ASSIGN_ONCE instead.
*/
#define __ACCESS_ONCE(x) ({ \
__maybe_unused typeof(x) __var = 0; \
__maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
(volatile typeof(x) *)&(x); })
#define ACCESS_ONCE(x) (*__ACCESS_ONCE(x))

Expand Down

0 comments on commit c5b1994

Please sign in to comment.