Skip to content

Commit

Permalink
perf ui hist browser: Fix segfault on 'a' for annotate
Browse files Browse the repository at this point in the history
There a typo in util/ui/browsers/hists.c that leads to a segfault when you
press the 'a' key on a non-resolved symbol (plain hex address).

LKML-Reference: <20100923201901.GE31726@gambetta>
Signed-off-by: Frederik Deweerdt <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
Frederik Deweerdt authored and acmel committed Oct 4, 2010
1 parent 39cfae6 commit c569d33
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/util/ui/browsers/hists.c
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ int hists__browse(struct hists *self, const char *helpline, const char *ev_name)

switch (key) {
case 'a':
if (browser->selection->map == NULL &&
if (browser->selection->map == NULL ||
browser->selection->map->dso->annotate_warned)
continue;
goto do_annotate;
Expand Down

0 comments on commit c569d33

Please sign in to comment.