Skip to content

Commit

Permalink
arch/sh: pcie-sh7786: handle non-zero DMA offset
Browse files Browse the repository at this point in the history
On SuperH, the base of the physical memory might be different from
zero. In this case, PCI address zero will map to a non-zero physical
address. In order to make sure that the DMA mapping API takes care of
this DMA offset, we must fill in the dev->dma_pfn_offset field for PCI
devices. This gets done in the pcibios_bus_add_device() hook, called
for each new PCI device detected.

The dma_pfn_offset global variable is re-calculated for every PCI
controller available on the platform, but that's not an issue because
its value will each time be exactly the same, as it only depends on
the memory start address and memory size.

Signed-off-by: Thomas Petazzoni <[email protected]>
Signed-off-by: Rich Felker <[email protected]>
  • Loading branch information
tpetazzoni authored and Rich Felker committed Apr 12, 2018
1 parent 79e1c5e commit bf9c7e3
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions arch/sh/drivers/pci/pcie-sh7786.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ struct sh7786_pcie_port {

static struct sh7786_pcie_port *sh7786_pcie_ports;
static unsigned int nr_ports;
static unsigned long dma_pfn_offset;

static struct sh7786_pcie_hwops {
int (*core_init)(void);
Expand Down Expand Up @@ -370,6 +371,8 @@ static int __init pcie_init(struct sh7786_pcie_port *port)
memstart = ALIGN_DOWN(memstart, memsize);
memsize = roundup_pow_of_two(memend - memstart);

dma_pfn_offset = memstart >> PAGE_SHIFT;

/*
* If there's more than 512MB of memory, we need to roll over to
* LAR1/LAMR1.
Expand Down Expand Up @@ -485,6 +488,11 @@ int pcibios_map_platform_irq(const struct pci_dev *pdev, u8 slot, u8 pin)
return evt2irq(0xae0);
}

void pcibios_bus_add_device(struct pci_dev *pdev)
{
pdev->dev.dma_pfn_offset = dma_pfn_offset;
}

static int __init sh7786_pcie_core_init(void)
{
/* Return the number of ports */
Expand Down

0 comments on commit bf9c7e3

Please sign in to comment.