Skip to content

Commit

Permalink
mm: free folios in a batch in shrink_folio_list()
Browse files Browse the repository at this point in the history
Use free_unref_page_batch() to free the folios.  This may increase the
number of IPIs from calling try_to_unmap_flush() more often, but that's
going to be very workload-dependent.  It may even reduce the number of
IPIs as we now batch-free large folios instead of freeing them one at a
time.

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: Ryan Roberts <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
Matthew Wilcox (Oracle) authored and akpm00 committed Mar 5, 2024
1 parent f77171d commit bc2ff4c
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions mm/vmscan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1006,14 +1006,15 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
struct pglist_data *pgdat, struct scan_control *sc,
struct reclaim_stat *stat, bool ignore_references)
{
struct folio_batch free_folios;
LIST_HEAD(ret_folios);
LIST_HEAD(free_folios);
LIST_HEAD(demote_folios);
unsigned int nr_reclaimed = 0;
unsigned int pgactivate = 0;
bool do_demote_pass;
struct swap_iocb *plug = NULL;

folio_batch_init(&free_folios);
memset(stat, 0, sizeof(*stat));
cond_resched();
do_demote_pass = can_demote(pgdat->node_id, sc);
Expand Down Expand Up @@ -1412,14 +1413,11 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
*/
nr_reclaimed += nr_pages;

/*
* Is there need to periodically free_folio_list? It would
* appear not as the counts should be low
*/
if (unlikely(folio_test_large(folio)))
destroy_large_folio(folio);
else
list_add(&folio->lru, &free_folios);
if (folio_batch_add(&free_folios, folio) == 0) {
mem_cgroup_uncharge_folios(&free_folios);
try_to_unmap_flush();
free_unref_folios(&free_folios);
}
continue;

activate_locked_split:
Expand Down Expand Up @@ -1483,9 +1481,9 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,

pgactivate = stat->nr_activate[0] + stat->nr_activate[1];

mem_cgroup_uncharge_list(&free_folios);
mem_cgroup_uncharge_folios(&free_folios);
try_to_unmap_flush();
free_unref_page_list(&free_folios);
free_unref_folios(&free_folios);

list_splice(&ret_folios, folio_list);
count_vm_events(PGACTIVATE, pgactivate);
Expand Down

0 comments on commit bc2ff4c

Please sign in to comment.