Skip to content

Commit

Permalink
cleancache: constify cleancache_ops structure
Browse files Browse the repository at this point in the history
The cleancache_ops structure is never modified, so declare it as const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
  • Loading branch information
JuliaLawall authored and konradwilk committed Jan 27, 2016
1 parent afd2ff9 commit b3c6de4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/xen/tmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ static int tmem_cleancache_init_shared_fs(char *uuid, size_t pagesize)
return xen_tmem_new_pool(shared_uuid, TMEM_POOL_SHARED, pagesize);
}

static struct cleancache_ops tmem_cleancache_ops = {
static const struct cleancache_ops tmem_cleancache_ops = {
.put_page = tmem_cleancache_put_page,
.get_page = tmem_cleancache_get_page,
.invalidate_page = tmem_cleancache_flush_page,
Expand Down
2 changes: 1 addition & 1 deletion include/linux/cleancache.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ struct cleancache_ops {
void (*invalidate_fs)(int);
};

extern int cleancache_register_ops(struct cleancache_ops *ops);
extern int cleancache_register_ops(const struct cleancache_ops *ops);
extern void __cleancache_init_fs(struct super_block *);
extern void __cleancache_init_shared_fs(struct super_block *);
extern int __cleancache_get_page(struct page *);
Expand Down
4 changes: 2 additions & 2 deletions mm/cleancache.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* cleancache_ops is set by cleancache_register_ops to contain the pointers
* to the cleancache "backend" implementation functions.
*/
static struct cleancache_ops *cleancache_ops __read_mostly;
static const struct cleancache_ops *cleancache_ops __read_mostly;

/*
* Counters available via /sys/kernel/debug/cleancache (if debugfs is
Expand All @@ -49,7 +49,7 @@ static void cleancache_register_ops_sb(struct super_block *sb, void *unused)
/*
* Register operations for cleancache. Returns 0 on success.
*/
int cleancache_register_ops(struct cleancache_ops *ops)
int cleancache_register_ops(const struct cleancache_ops *ops)
{
if (cmpxchg(&cleancache_ops, NULL, ops))
return -EBUSY;
Expand Down

0 comments on commit b3c6de4

Please sign in to comment.