Skip to content

Commit

Permalink
[MIPS] Fix sparsemem support.
Browse files Browse the repository at this point in the history
    
Move memory_present() in arch/mips/kernel/setup.c. When using sparsemem
extreme, this function does an allocate for bootmem. This would always
fail since init_bootmem hasn't been called yet.
    
Move memory_present after free_bootmem. This only marks actual memory
ranges as present instead of the entire address space.
    
Signed-off-by: Chad Reese  <[email protected]>
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
Chad Reese authored and ralfbaechle committed Jun 5, 2006
1 parent ecf52d3 commit b1c231f
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 3 deletions.
3 changes: 1 addition & 2 deletions arch/mips/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,6 @@ static inline void bootmem_init(void)
}
#endif

memory_present(0, first_usable_pfn, max_low_pfn);

/* Initialize the boot-time allocator with low memory only. */
bootmap_size = init_bootmem(first_usable_pfn, max_low_pfn);

Expand Down Expand Up @@ -410,6 +408,7 @@ static inline void bootmem_init(void)

/* Register lowmem ranges */
free_bootmem(PFN_PHYS(curr_pfn), PFN_PHYS(size));
memory_present(0, curr_pfn, curr_pfn + size - 1);
}

/* Reserve the bootmap memory. */
Expand Down
2 changes: 1 addition & 1 deletion arch/mips/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ void __init mem_init(void)
for (tmp = 0; tmp < max_low_pfn; tmp++)
if (page_is_ram(tmp)) {
ram++;
if (PageReserved(mem_map+tmp))
if (PageReserved(pfn_to_page(tmp)))
reservedpages++;
}

Expand Down
2 changes: 2 additions & 0 deletions include/asm-mips/page.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,11 @@ typedef struct { unsigned long pgprot; } pgprot_t;

#define pfn_to_kaddr(pfn) __va((pfn) << PAGE_SHIFT)

#ifndef CONFIG_SPARSEMEM
#ifndef CONFIG_NEED_MULTIPLE_NODES
#define pfn_valid(pfn) ((pfn) < max_mapnr)
#endif
#endif

#define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
Expand Down
14 changes: 14 additions & 0 deletions include/asm-mips/sparsemem.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#ifndef _MIPS_SPARSEMEM_H
#define _MIPS_SPARSEMEM_H
#ifdef CONFIG_SPARSEMEM

/*
* SECTION_SIZE_BITS 2^N: how big each section will be
* MAX_PHYSMEM_BITS 2^N: how much memory we can have in that space
*/
#define SECTION_SIZE_BITS 28
#define MAX_PHYSMEM_BITS 35

#endif /* CONFIG_SPARSEMEM */
#endif /* _MIPS_SPARSEMEM_H */

0 comments on commit b1c231f

Please sign in to comment.