Skip to content

Commit

Permalink
bootup: move 'usermodehelper_enable()' a little earlier
Browse files Browse the repository at this point in the history
Commit d5767c5 ("bootup: move 'usermodehelper_enable()' to the end
of do_basic_setup()") moved 'usermodehelper_enable()' to end of
do_basic_setup() to after the initcalls.  But then I get failed to let
uvesafb work on my computer, and lose the splash boot.

So maybe we could start usermodehelper_enable a little early to make
some task work that need eary init with the help of user mode.

[ I would *really* prefer that initcalls not call into user space - even
  the real 'init' hasn't been execve'd yet, after all! But for uvesafb
  it really does look like we don't have much choice.

  I considered doing this when we mount the root filesystem, but
  depending on config options that is in multiple places.  We could do
  the usermode helper enable as a rootfs_initcall()..

  So I'm just using wang yanqing's trivial patch.  It's not wonderful,
  but it's simple and should work.  We should revisit this some day,
  though.      - Linus ]

Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
wyqkp authored and torvalds committed Sep 30, 2011
1 parent d5767c5 commit b0f8437
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,8 @@ static void __init do_basic_setup(void)
driver_init();
init_irq_proc();
do_ctors();
do_initcalls();
usermodehelper_enable();
do_initcalls();
}

static void __init do_pre_smp_initcalls(void)
Expand Down

0 comments on commit b0f8437

Please sign in to comment.