Skip to content

Commit

Permalink
asm-generic: Drop renameat syscall from default list
Browse files Browse the repository at this point in the history
The newer renameat2 syscall provides all the functionality provided by
the renameat syscall and adds flags, so future architectures won't need
to include renameat.

Therefore drop the renameat syscall from the generic syscall list unless
__ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to
including asm-generic/unistd.h, and adjust all architectures using the
generic syscall list to define it so that no in-tree architectures are
affected.

Signed-off-by: James Hogan <[email protected]>
Acked-by: Vineet Gupta <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: [email protected]
Cc: Mark Salter <[email protected]>
Cc: Aurelien Jacquiot <[email protected]>
Cc: [email protected]
Cc: Richard Kuo <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Jonas Bonn <[email protected]>
Cc: [email protected]
Cc: Chen Liqin <[email protected]>
Cc: Lennox Wu <[email protected]>
Cc: Chris Metcalf <[email protected]>
Cc: Guan Xuetao <[email protected]>
Cc: Ley Foon Tan <[email protected]>
Cc: [email protected]
Cc: Yoshinori Sato <[email protected]>
Cc: [email protected]
Signed-off-by: Arnd Bergmann <[email protected]>
  • Loading branch information
James Hogan authored and arndb committed May 4, 2016
1 parent 1f93e9f commit b0da6d4
Show file tree
Hide file tree
Showing 12 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions arch/arc/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#if !defined(_UAPI_ASM_ARC_UNISTD_H) || defined(__SYSCALL)
#define _UAPI_ASM_ARC_UNISTD_H

#define __ARCH_WANT_RENAMEAT
#define __ARCH_WANT_SYS_EXECVE
#define __ARCH_WANT_SYS_CLONE
#define __ARCH_WANT_SYS_VFORK
Expand Down
3 changes: 3 additions & 0 deletions arch/arm64/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

#define __ARCH_WANT_RENAMEAT

#include <asm-generic/unistd.h>
1 change: 1 addition & 0 deletions arch/c6x/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* more details.
*/

#define __ARCH_WANT_RENAMEAT
#define __ARCH_WANT_SYS_CLONE

/* Use the standard ABI for syscalls. */
Expand Down
2 changes: 2 additions & 0 deletions arch/h8300/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#define __ARCH_NOMMU

#define __ARCH_WANT_RENAMEAT

#include <asm-generic/unistd.h>
1 change: 1 addition & 0 deletions arch/hexagon/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
*/

#define sys_mmap2 sys_mmap_pgoff
#define __ARCH_WANT_RENAMEAT
#define __ARCH_WANT_SYS_EXECVE
#define __ARCH_WANT_SYS_CLONE
#define __ARCH_WANT_SYS_VFORK
Expand Down
2 changes: 2 additions & 0 deletions arch/metag/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
* (at your option) any later version.
*/

#define __ARCH_WANT_RENAMEAT

/* Use the standard ABI for syscalls. */
#include <asm-generic/unistd.h>

Expand Down
2 changes: 2 additions & 0 deletions arch/nios2/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

#define sys_mmap2 sys_mmap_pgoff

#define __ARCH_WANT_RENAMEAT

/* Use the standard ABI for syscalls */
#include <asm-generic/unistd.h>

Expand Down
1 change: 1 addition & 0 deletions arch/openrisc/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#define sys_mmap2 sys_mmap_pgoff

#define __ARCH_WANT_RENAMEAT
#define __ARCH_WANT_SYS_FORK
#define __ARCH_WANT_SYS_CLONE

Expand Down
1 change: 1 addition & 0 deletions arch/score/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#define __ARCH_HAVE_MMU

#define __ARCH_WANT_RENAMEAT
#define __ARCH_WANT_SYSCALL_NO_AT
#define __ARCH_WANT_SYSCALL_NO_FLAGS
#define __ARCH_WANT_SYSCALL_OFF_T
Expand Down
1 change: 1 addition & 0 deletions arch/tile/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* more details.
*/

#define __ARCH_WANT_RENAMEAT
#if !defined(__LP64__) || defined(__SYSCALL_COMPAT)
/* Use the flavor of this syscall that matches the 32-bit API better. */
#define __ARCH_WANT_SYNC_FILE_RANGE2
Expand Down
2 changes: 2 additions & 0 deletions arch/unicore32/include/uapi/asm/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
* published by the Free Software Foundation.
*/

#define __ARCH_WANT_RENAMEAT

/* Use the standard ABI for syscalls. */
#include <asm-generic/unistd.h>
#define __ARCH_WANT_SYS_CLONE
3 changes: 3 additions & 0 deletions include/uapi/asm-generic/unistd.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,11 @@ __SYSCALL(__NR_unlinkat, sys_unlinkat)
__SYSCALL(__NR_symlinkat, sys_symlinkat)
#define __NR_linkat 37
__SYSCALL(__NR_linkat, sys_linkat)
#ifdef __ARCH_WANT_RENAMEAT
/* renameat is superseded with flags by renameat2 */
#define __NR_renameat 38
__SYSCALL(__NR_renameat, sys_renameat)
#endif /* __ARCH_WANT_RENAMEAT */

/* fs/namespace.c */
#define __NR_umount2 39
Expand Down

0 comments on commit b0da6d4

Please sign in to comment.